Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick bug fixes to 1.5 release #373

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Cherry-pick bug fixes to 1.5 release #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba9a0f4
Re-enable mysql for s3-only pipelines deployment. (#310)
jsitu777 Aug 10, 2022
3e1c8e4
update RDS MYSQL Version (#341)
jsitu777 Sep 2, 2022
b607847
Add minioServiceHost var substitution to rds and s3 kustomization (#333)
rrrkharse Aug 26, 2022
0de58c7
Enable secure connection in minio config for S3 integration (#244)
rrrkharse May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions awsconfigs/apps/pipeline/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,12 @@ patchesStrategicMerge:
# when application is deleted.
commonLabels:
application-crd-id: kubeflow-pipelines
vars:
- name: kfp-artifact-storage-endpoint
objref:
kind: ConfigMap
name: pipeline-install-config
apiVersion: v1
fieldref:
fieldpath: data.minioServiceHost

2 changes: 1 addition & 1 deletion awsconfigs/apps/pipeline/s3/config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ artifactRepository:
bucket: $(kfp-artifact-bucket-name),
keyPrefix: artifacts,
endpoint: $(kfp-artifact-storage-endpoint),
insecure: true,
insecure: false,
accessKeySecret: {
name: mlpipeline-minio-artifact,
key: accesskey
Expand Down
26 changes: 0 additions & 26 deletions awsconfigs/apps/pipeline/s3/disable-mysql-pv-claim.yaml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion awsconfigs/apps/pipeline/s3/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ generatorOptions:
disableNameSuffixHash: true
patchesStrategicMerge:
- disable-default-secret.yaml
- disable-mysql-pv-claim.yaml
- aws-configuration-patch.yaml
# Identifier for application manager to apply ownerReference.
# The ownerReference ensures the resources get garbage collected
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/resources/cloudformation-templates/rds-s3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Resources:
DBInstanceClass:
Ref: DBClass
Engine: MySQL
EngineVersion: "8.0.17"
EngineVersion: "8.0.28"
MultiAZ:
Ref: MultiAZ
MasterUsername:
Expand Down