modify istio-1-14 paths and helm chart based on kubeflow patch release #446
Conversation
|
missing changes from kubeflow/manifests#2287 |
| @@ -7,5 +7,5 @@ bases: | |||
| images: | |||
| - name: gcr.io/ml-pipeline/api-server | |||
| newName: public.ecr.aws/c9e4w0g3/ml-pipeline/api-server | |||
| newTag: 2.0.0-alpha.3 | |||
| newTag: 2.0.0-alpha.5 | |||
There was a problem hiding this comment.
we dont have this image right now, @akartsky will update this later. keep it to .3 for now
There was a problem hiding this comment.
Reverted back the image. Feel free to merge this.
There was a problem hiding this comment.
Only this image
public.ecr.aws/c9e4w0g3/ml-pipeline/api-server
There was a problem hiding this comment.
so in the helm charts they will be alpha.5?
There was a problem hiding this comment.
I mean both helm and kustomize but only this image because .5 does not exist as of now
All other images same as upstream
Basically, build it with public.ecr.aws/c9e4w0g3/ml-pipeline/api-server:2.0.0-alpha.3
There was a problem hiding this comment.
Now should be good. deployment tag is alpha.3 while the rest follow upstream to be alpha.5
|
Need to update other installation_configs for istio |
There was a problem hiding this comment.
approving since the rest of the installation configs already have the required istio path. This is a bug in 1.6.0-aws-b1.0.0 since it should have pointed the aws overlays. This affects only kustomize installations except vanilla
Pipeline api-server image needs to be updated as part of a separate PR
These will will be fixed with next release
Which issue is resolved by this Pull Request:
Resolves #
kubeflow/manifests#2288
Description of your changes:
-update istio paths with newest patch update.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.