Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notebook Culling Feature Doc #490

Merged
merged 34 commits into from
Nov 22, 2022
Merged

Add Notebook Culling Feature Doc #490

merged 34 commits into from
Nov 22, 2022

Conversation

jsitu777
Copy link
Contributor

Which issue is resolved by this Pull Request:
Resolves # #439

Description of your changes:
-Added documentation in notebook component guide for culling feature

jsitu777 and others added 21 commits October 10, 2022 15:40
…me to be internet facing in sanity test and configure ingress function.
Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, few comments

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor changes requested

@jsitu777 jsitu777 merged commit 3e605fb into main Nov 22, 2022
@jsitu777 jsitu777 deleted the notebook-culling-doc branch November 22, 2022 23:15
jsitu777 added a commit that referenced this pull request Nov 23, 2022
**Which issue is resolved by this Pull Request:**
Resolves # #439

**Description of your changes:**
-Added documentation in notebook component guide for culling feature

(cherry picked from commit 3e605fb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants