-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kserve Doc for configuring IRSA to access AWS services #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
requested changes
Nov 16, 2022
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
surajkota
requested changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs in good shape, thanks, few minor comments
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-service-from-kserve.md
Outdated
Show resolved
Hide resolved
surajkota
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, almost ready to merge
website/content/en/docs/component-guides/kserve/access-aws-services-from-kserve.md
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-services-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-services-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-services-from-kserve.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/component-guides/kserve/access-aws-services-from-kserve.md
Outdated
Show resolved
Hide resolved
surajkota
approved these changes
Nov 22, 2022
jsitu777
added a commit
that referenced
this pull request
Nov 23, 2022
-add documentation for accessing aws service in Kserve with IRSA #436 kserve/kserve#2003 (comment) Reference: https://github.com/kserve/website/blob/main/docs/modelserving/storage/s3/s3.md (cherry picked from commit 8e2ffc5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-add documentation for accessing aws service in Kserve with IRSA
#436
kserve/kserve#2003 (comment)
Reference:
https://github.com/kserve/website/blob/main/docs/modelserving/storage/s3/s3.md