Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed katib installation helm path #504

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fixed katib installation helm path #504

merged 1 commit into from
Nov 14, 2022

Conversation

prli
Copy link
Contributor

@prli prli commented Nov 12, 2022

Which issue is resolved by this Pull Request:
N.A

Description of your changes:
helm installation path is incorrect, results in Chart.yaml not found error.

==========Installing katib==========
Error: Chart.yaml file is missing
Traceback (most recent call last):
  File "utils/kubeflow_installation.py", line 249, in <module>
    install_kubeflow(

Testing:

  • [ N.A] Unit tests pass
  • [ N.A] e2e tests pass

make deploy-kubeflow INSTALLATION_OPTION=helm DEPLOYMENT_OPTION=s3-only runs without errors now.

Waiting for katib pods to be ready ...
running command: kubectl wait --for=condition=ready pod -l 'katib.kubeflow.org/component in (controller, db-manager, ui)' --timeout=240s -n kubeflow
pod/katib-controller-75b988dccc-4r5j8 condition met
pod/katib-db-manager-5d46869758-4lvvp condition met
pod/katib-ui-766d5dc8ff-47md2 condition met
All katib pods are running!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jsitu777 jsitu777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This is a miss on our side.

@jsitu777 jsitu777 merged commit 3de7c31 into awslabs:main Nov 14, 2022
jsitu777 pushed a commit that referenced this pull request Nov 14, 2022
**Which issue is resolved by this Pull Request:**
N.A

**Description of your changes:**
helm installation path is incorrect, results in `Chart.yaml` not found
error.
```
==========Installing katib==========
Error: Chart.yaml file is missing
Traceback (most recent call last):
  File "utils/kubeflow_installation.py", line 249, in <module>
    install_kubeflow(
```

**Testing:**
- [ N.A] Unit tests pass
- [ N.A] e2e tests pass

`make deploy-kubeflow INSTALLATION_OPTION=helm
DEPLOYMENT_OPTION=s3-only` runs without errors now.

```
Waiting for katib pods to be ready ...
running command: kubectl wait --for=condition=ready pod -l 'katib.kubeflow.org/component in (controller, db-manager, ui)' --timeout=240s -n kubeflow
pod/katib-controller-75b988dccc-4r5j8 condition met
pod/katib-db-manager-5d46869758-4lvvp condition met
pod/katib-ui-766d5dc8ff-47md2 condition met
All katib pods are running!
```

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@prli prli deleted the patch-1 branch November 15, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants