Task/s3nopublic #518
Merged
Task/s3nopublic #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
approved these changes
Dec 12, 2022
ryansteakley
approved these changes
Dec 12, 2022
|
Thanks for the contribution! |
|
@rddefauw Can you resolve the conflict then I can merge this in for you :) |
|
Done - was just a simple documentation change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Configure "block public access" by default for the S3 artifact bucket, when deployed both via terraform and manifests.
Testing:
Deployed using both methods and verified things worked as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.