Cleanup ACK add try/except for detaching policy #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananth102
approved these changes
Feb 27, 2023
jsitu777
approved these changes
Feb 27, 2023
ryansteakley
added a commit
to ryansteakley/kubeflow-manifests
that referenced
this pull request
Mar 16, 2023
**Description of your changes:** Cleanup may fail in edge-case where the policy was already deleted/detached before the clean-up was run. In this case the role will never be deleted. Then in future runs of ACK creation in that same account it would not create the role again, thus the role would have a missing policy and be unable to run SM jobs **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Cleanup may fail in edge-case where the policy was already deleted/detached before the clean-up was run. In this case the role will never be deleted. Then in future runs of ACK creation in that same account it would not create the role again, thus the role would have a missing policy and be unable to run SM jobs
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.