Charts for IRSA support with Helm #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsitu777
reviewed
Mar 3, 2023
jsitu777
reviewed
Mar 3, 2023
awsconfigs/apps/pipeline/s3-static/disable-minio-server-resources.yaml
Outdated
Show resolved
Hide resolved
ananth102
reviewed
Mar 3, 2023
jsitu777
reviewed
Mar 14, 2023
jsitu777
approved these changes
Mar 14, 2023
|
looks good, can you also trim the role name here |
ananth102
approved these changes
Mar 14, 2023
ryansteakley
added a commit
to ryansteakley/kubeflow-manifests
that referenced
this pull request
Apr 14, 2023
**Which issue is resolved by this Pull Request:** Resolves # **Description of your changes:** Includes chart changes for IRSA for helm and basic implementation of installation and makefile changes to support installation. Putting it up for review, will continue to iterate on the installation code but need review on basics asap **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Includes chart changes for IRSA for helm and basic implementation of installation and makefile changes to support installation. Putting it up for review, will continue to iterate on the installation code but need review on basics asap
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.