Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sagemaker Controller Version #671

Merged
merged 13 commits into from
Apr 12, 2023
Merged

Update Sagemaker Controller Version #671

merged 13 commits into from
Apr 12, 2023

Conversation

jsitu777
Copy link
Contributor

  • update sagemaker controller chart to latest version

jsitu777 and others added 12 commits March 30, 2023 13:08
@ananth102
Copy link
Contributor

ananth102 commented Apr 12, 2023 •
edited
Loading

Can you update this directory(https://github.com/jsitu777/kubeflow-manifests/tree/sagemaker-controller/awsconfigs/common/ack-sagemaker-controller/base) there are some new rbac permissions/crds https://github.com/aws-controllers-k8s/sagemaker-controller/blob/dca96d4e4c10fa8e9b07282e667ea3c323d2167e/config/rbac/cluster-role-controller.yaml#L377

@jsitu777
Copy link
Contributor Author

Can you update this directory(https://github.com/jsitu777/kubeflow-manifests/tree/sagemaker-controller/awsconfigs/common/ack-sagemaker-controller/base) there are some new rbac permissions/crds https://github.com/aws-controllers-k8s/sagemaker-controller/blob/dca96d4e4c10fa8e9b07282e667ea3c323d2167e/config/rbac/cluster-role-controller.yaml#L377

updated @ananth102

@jsitu777 jsitu777 requested a review from ananth102 April 12, 2023 18:34
@jsitu777 jsitu777 merged commit 82a55c5 into awslabs:main Apr 12, 2023
@jsitu777 jsitu777 deleted the sagemaker-controller branch April 12, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananth102 ananth102 ananth102 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsitu777 @ananth102