Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Empty Credential Strings in Kserve IRSA configuration #673

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Remove Empty Credential Strings in Kserve IRSA configuration #673

merged 2 commits into from
Apr 14, 2023

Conversation

jsitu777
Copy link
Contributor

  • remove empty credential string in Secret for Kserve IRSA configuration as it's no longer needed
  • separate s3 bucket for kserve and s3 bucket for sagemaker

Testing:

  • Unit tests pass
  • e2e tests pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jsitu777 jsitu777 requested a review from ryansteakley April 13, 2023 01:29
@jsitu777 jsitu777 merged commit bd7d3e6 into awslabs:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreBrown AlexandreBrown AlexandreBrown approved these changes

@surajkota surajkota surajkota approved these changes

@ryansteakley ryansteakley Awaiting requested review from ryansteakley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsitu777 @surajkota @AlexandreBrown