Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KFP IRSA docs #680

Merged
merged 10 commits into from
Apr 21, 2023
Merged

KFP IRSA docs #680

merged 10 commits into from
Apr 21, 2023

Conversation

ryansteakley
Copy link
Contributor

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Was requested to open against main for feedback this is a rough rough draft.

Testing:

  • Unit tests pass
  • e2e tests pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansteakley ryansteakley changed the title [Draft] KFP IRSA docs KFP IRSA docs Apr 20, 2023
@ananth102
Copy link
Contributor

website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
{{< /tab >}}
{{< tab header="Helm" lang="yaml" >}}
make delete-kubeflow INSTALLATION_OPTION=helm DEPLOYMENT_OPTION=rds-s3
make delete-kubeflow INSTALLATION_OPTION=helm DEPLOYMENT_OPTION=rds-s3 PIPELINE_S3_CREDENTIAL_OPTION=irsa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a separate section for creating additional profiles if using IRSA because having an IAM role is a requirement now. A separate page for it might be better so we can link to it from multiple pages terraform and cognito-rds-s3 etc.

Copy link
Contributor Author

@ryansteakley ryansteakley Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just link here https://awslabs.github.io/kubeflow-manifests/docs/component-guides/profiles/ isn't that essentially what this guide is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to use parts it but we still need documentation indicating access to S3 bucket. It will be good to use profiles guide as a reference but have a specific sample

website/content/en/docs/deployment/cognito-rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/cognito-rds-s3/guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, small changes requested

website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/rds-s3/guide.md Outdated Show resolved Hide resolved
{{< /tab >}}
{{< tab header="Helm" lang="yaml" >}}
make delete-kubeflow INSTALLATION_OPTION=helm DEPLOYMENT_OPTION=rds-s3
make delete-kubeflow INSTALLATION_OPTION=helm DEPLOYMENT_OPTION=rds-s3 PIPELINE_S3_CREDENTIAL_OPTION=irsa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to use parts it but we still need documentation indicating access to S3 bucket. It will be good to use profiles guide as a reference but have a specific sample

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR!

cc @krhoyt this was the expected doc update for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants