Move running of bootstrap-pipelines to auto-rds-s3-setup #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
requested changes
Apr 18, 2023
surajkota
requested changes
Apr 19, 2023
surajkota
reviewed
Apr 19, 2023
surajkota
requested changes
Apr 19, 2023
There was a problem hiding this comment.
@ryansteakley Great work on this PR!
requested small changes, lgtm otherwise
surajkota
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Should only run as part of deployments running rds/s3 flavors
Keeping it in the makefile additionally to support users who want to run it if they are using s3-only and/or do not wish to run the auto-rds-s3-setup script in its entirety.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.