-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about creating Pipeline Profiles #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few changes requested, reviewed at high level
website/content/en/docs/deployment/cognito-rds-s3/guide-terraform.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please address comments and merge asap
"Condition": { | ||
"StringEquals": { | ||
"${OIDC_URL}:aud": "sts.amazonaws.com", | ||
"${OIDC_URL}:sub": "system:serviceaccount:kubeflow-user-example-com:default-editor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug, this should correspond to profile namespace
|
||
6. Create a user in your configured auth provider (e.g. Cognito or Dex). | ||
|
||
Export the user as an environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export the user email as env variable, e.g. user@example.com
**Which issue is resolved by this Pull Request:** Resolves # **Description of your changes:** Add information about how to create Profiles that use IRSA and have correct s3 bucket access for Pipelines. **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
**Which issue is resolved by this Pull Request:** Resolves # **Description of your changes:** Add information about how to create Profiles that use IRSA and have correct s3 bucket access for Pipelines. **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Add information about how to create Profiles that use IRSA and have correct s3 bucket access for Pipelines.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.