Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about creating Pipeline Profiles #700

Merged
merged 9 commits into from
May 2, 2023

Conversation

ryansteakley
Copy link
Contributor

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Add information about how to create Profiles that use IRSA and have correct s3 bucket access for Pipelines.

Testing:

  • Unit tests pass
  • e2e tests pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes requested, reviewed at high level

website/content/en/docs/deployment/cognito-rds-s3/guide.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please address comments and merge asap

website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
website/content/en/docs/deployment/pipeline-profiles.md Outdated Show resolved Hide resolved
@ryansteakley ryansteakley merged commit d245504 into awslabs:main May 2, 2023
"Condition": {
"StringEquals": {
"${OIDC_URL}:aud": "sts.amazonaws.com",
"${OIDC_URL}:sub": "system:serviceaccount:kubeflow-user-example-com:default-editor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug, this should correspond to profile namespace


6. Create a user in your configured auth provider (e.g. Cognito or Dex).

Export the user as an environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export the user email as env variable, e.g. user@example.com

ryansteakley added a commit to ryansteakley/kubeflow-manifests that referenced this pull request May 3, 2023
**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**
Add information about how to create Profiles that use IRSA and have
correct s3 bucket access for Pipelines.

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
jsitu777 pushed a commit to jsitu777/kubeflow-manifests that referenced this pull request Jun 27, 2023
**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**
Add information about how to create Profiles that use IRSA and have
correct s3 bucket access for Pipelines.

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants