Update main.tf #751
Merged
Update main.tf #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for error - Error: Unsupported argument enable_classiclink_dns_support = null # hashicorp/terraform#31730
surajkota
requested changes
Jun 2, 2023
| @@ -187,7 +187,7 @@ module "kubeflow_components" { | |||
| #--------------------------------------------------------------- | |||
| module "vpc" { | |||
| source = "terraform-aws-modules/vpc/aws" | |||
| version = "3.14.4" | |||
| version = "5.0.0" | |||
There was a problem hiding this comment.
Thanks for the PR, Could you update other stacks as well?
https://github.com/search?q=repo%3Aawslabs%2Fkubeflow-manifests%20terraform-aws-modules&type=code
|
Looks good, will test on my end and merge. |
ananth102
approved these changes
Jun 7, 2023
surajkota
approved these changes
Jun 7, 2023
|
Thanks for the PR |
jsitu777
pushed a commit
to jsitu777/kubeflow-manifests
that referenced
this pull request
Jun 27, 2023
Fix for error - Error: Unsupported argument enable_classiclink_dns_support = null # hashicorp/terraform#31730 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for error - Error: Unsupported argument enable_classiclink_dns_support = null # hashicorp/terraform#31730
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.