Upgrading eks blueprints to v4.32.1 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
approved these changes
Aug 8, 2023
|
does the new version also address the missing permissions? |
ryansteakley
approved these changes
Aug 8, 2023
|
@surajkota Too many changes for 1 pr |
AlexandreBrown
pushed a commit
to AlexandreBrown/Kubeflow
that referenced
this pull request
Oct 3, 2023
- Based on branch test-kfpv2 - Upgraded EKS Blueprints Addons to fix terraform init - aws-ia/terraform-aws-eks-blueprints#1630 (comment) - Manually applied : awslabs/kubeflow-manifests#776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Terraform deployments are not working because eks blueprints before v4.32.1 did not pin their version in the main.tf file. As a result terraform pulled the modules from the main branch. Last week eks blueprints removed the modules as part of their refactoring effort which breaks any version before v4.32.1.
Further reading:
aws-ia/terraform-aws-eks-blueprints#1699
aws-ia/terraform-aws-eks-blueprints#1630 (comment)
Description of your changes:
Upgrade terraform-aws-eks-blueprints from
v4.31.0tov4.32.1Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.