Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to pass variable mysql_engine_version to RDS module #781

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

elanv
Copy link
Contributor

@elanv elanv commented Aug 17, 2023

Which issue is resolved by this Pull Request:
Resolves #780

Description of your changes:
Fix to pass variable mysql_engine_version to RDS module.

Testing:

  • Unit tests pass
  • e2e tests pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ananth102 ananth102 merged commit 01ac3b6 into awslabs:main Aug 24, 2023
@ananth102
Copy link
Contributor

Thanks for the contribution!

rakuto pushed a commit to tne-ai/kubeflow-manifests that referenced this pull request Sep 27, 2023
**Which issue is resolved by this Pull Request:**
Resolves awslabs#780 

**Description of your changes:**
Fix to pass variable `mysql_engine_version` to RDS module.

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring mysql_engine_version does not work
3 participants