Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rds engine version in terraform deployments #785

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

ananth102
Copy link
Contributor

@ananth102 ananth102 commented Aug 28, 2023

Update rds engine version to 8.0.33

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Updates rds engine version

Testing:

  • Unit tests pass
  • e2e tests pass - rds/s3 test passed
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed
PASSED
--
5932 | tests/terraform/test_rds_s3.py::TestRDSS3Terraform::test_verify_mlpipeline_db PASSED
5933 | tests/terraform/test_rds_s3.py::TestRDSS3Terraform::test_verify_mlmdb PASSED
5934 | tests/terraform/test_rds_s3.py::TestRDSS3Terraform::test_s3_bucket_is_being_used_as_metadata_store PASSED
5935 | tests/terraform/test_rds_s3.py::TestRDSS3Terraform::test_kfp_experiment Forwarding from 127.0.0.1:8080 -> 8080
5936 | Handling connection for 8080
5937 | Handling connection for 8080
5938 |  
5939 | -------------------------------- live log call ---------------------------------
5940 | INFO     root:_client.py:456 Creating experiment experiment-mqe8btvlg5.
5941 | PASSED
5942 | tests/terraform/test_rds_s3.py::TestRDSS3Terraform::test_run_pipeline
5943 | -------------------------------- live log call ---------------------------------
5944 | INFO     root:_client.py:456 Creating experiment experiment-iv8yyghl65.
5945 | PASSED

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Update rds engine version to 8.0.33
@ananth102 ananth102 merged commit 5127d38 into awslabs:main Aug 28, 2023
@@ -45,7 +45,7 @@ variable "db_allocated_storage" {
variable "mysql_engine_version" {
type = string
description = "The engine version of MySQL"
default = "8.0.32"
default = "8.0.33"
Copy link
Contributor

@surajkota surajkota Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating here will not work because the parent stack is overriding the version, e.g.

also can we bump to latest supported? 8.0.34?

@surajkota surajkota mentioned this pull request Aug 28, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants