Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GroupInfo public and fix docs #132

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Make GroupInfo public and fix docs #132

merged 1 commit into from
Mar 28, 2024

Conversation

mulmarta
Copy link
Contributor

GroupInfo is in one variant of the public ReceivedMessage enum, so should be public. Also ClientConfig in UniFFI should be public, I think.

Also fixed all warnings generated by cago doc --all-features.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner March 27, 2024 11:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (d54563f) to head (400e2d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         173      173           
  Lines       31450    31450           
=======================================
  Hits        28151    28151           
  Misses       3299     3299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit 23a59ba into main Mar 28, 2024
20 checks passed
@tomleavy tomleavy deleted the fixup branch March 28, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants