Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uniffi] Explain what an “application message” is #138

Merged

Conversation

mgeisler
Copy link
Contributor

@mgeisler mgeisler commented Apr 3, 2024

Issues:

Addresses #81.

Description of changes:

This expands the docstring a little for the ReceivedMessage::ApplicationMessage enum and the encrypt_application_message method.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mgeisler mgeisler requested a review from a team as a code owner April 3, 2024 13:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (8f7d38b) to head (4bc055f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         173      173           
  Lines       31450    31450           
=======================================
  Hits        28156    28156           
  Misses       3294     3294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit 973b904 into awslabs:main Apr 3, 2024
13 checks passed
@mgeisler mgeisler deleted the uniffi-application-message-docstring branch April 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants