Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy warnings on Rust 1.83 #1175

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

unexge
Copy link
Contributor

@unexge unexge commented Nov 28, 2024

Rust 1.83 has been released with new Clippy lints, and it broke our CI as we use stable toolchain.

This PR fixes Clippy warnings on Rust 1.83. Most fixes are done with cargo clippy --fix and manually checked.

Does this change impact existing behavior?

None expected, it just changes the code style.

Does this change need a changelog entry?

No, as there is no behavioral change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Burak Varli <burakvar@amazon.co.uk>
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
@unexge unexge temporarily deployed to PR integration tests November 28, 2024 17:51 — with GitHub Actions Inactive
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannycjones dannycjones added this pull request to the merge queue Nov 28, 2024
Merged via the queue into awslabs:main with commit b041775 Nov 28, 2024
23 checks passed
@unexge unexge deleted the fix-clippy-lints-on-rust-1.83 branch December 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants