Bump aws-c-s3 to v0.2.9 #228
Conversation
This picks up the fix for awslabs#218. Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
There was a problem hiding this comment.
What is the process to upgrade the crt for our Mountpoint? I got the changes that are in the update like yml files issue template and workflow on github and changes to include the case of bytes = "0-0".
And there is a test for it as well, so that should be fine.
#226 should pass now I guess.
There was a problem hiding this comment.
That's a good question. Would it be helpful if the PR (maybe an automated comment) would point you to this document?
Also, does it feel like there's information missing?
I think what we really need to do is review the commit history (not the diff), and if there's anything that sounds relevant for us - we should dig deeper and check there's no changes we care about. For example, we should worry if the lifetime (in C) changes for a parameter we pass in.
There was a problem hiding this comment.
Yes, got it. The document explains the process for updating the submodule, not the reviewer right?
Yes, for the first time reviewer an automated comment about the document will help.
There was a problem hiding this comment.
Yeah, maybe we can add some pointers for what a reviewer should look for.
Improve PartQueue to report an error (rather than blocking indeterminately) when trying to read beyond the body returned by the GetObject request. The previous behavior, compounded with a bug in the CRT (now fixed: #228) where GetObject unexpectedly returned an empty body, manifested in #218. --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
This picks up the fix for #218.
Signed-off-by: James Bornholt bornholt@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).