Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for ETags and FUSE operation flags #618

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dannycjones
Copy link
Contributor

Description of change

Small logging improvements I wanted to make while debugging #614.

  • It was useful to include the ETag at different points, but the named-field struct for ETag meant the Debug format was noisy. Moving to a tuple struct is simple and ETag is now formatted as ETag("etag").
  • FUSE operations which take flags were originally formatting the flags as decimal numbers. It's appears easier to interpret the flags when using binary usually, so we update the logs to format those numbers as binary like 0b10010101.
  • Some of the logs on their own weren't useful. For example, we know an Inode lookup count was incremented but we only know the parent Inode. Fix that by including the Inode number that actually had its count incremented.
  • We never emitted the new file handle number before use - now we do that.

Relevant issues: N/A

Does this change impact existing behavior?

No breaking changes.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
@dannycjones dannycjones temporarily deployed to PR integration tests November 21, 2023 08:00 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 21, 2023 08:00 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 21, 2023 08:00 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 21, 2023 08:00 — with GitHub Actions Inactive
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannycjones dannycjones added this pull request to the merge queue Nov 21, 2023
Merged via the queue into awslabs:main with commit 661d0fb Nov 21, 2023
18 checks passed
@dannycjones dannycjones deleted the improve-logging branch November 21, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants