Add metrics for number of inodes #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
This is a small change to their behavior: they'll now emit if they're changed to zero, whereas before they would not. But I think that's the behavior we want anyway. Signed-off-by: James Bornholt <bornholt@amazon.com>
We were abusing absolute counters to get the "only emit when changed" behavior, which gauges now provide too. Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
force-pushed
the
inode-metric
branch
from
af16ea5
to
df06246
Compare
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
We track the total number of inodes as well as tracking them by kind. Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
force-pushed
the
inode-metric
branch
from
df06246
to
e7dcfa0
Compare
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We track the total number of inodes as well as tracking them by kind. I did this by updating how we use gauges to work better for our current metrics stack, so that we don't just emit the same value every 5 seconds forever.
Does this change impact existing behavior?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).