Handled error to return the reason of failure as part of the response. #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidthomas426
requested changes
Mar 8, 2023
| logger.warning("Invoking custom service failed.", exc_info=True) | ||
| return create_predict_response(None, req_id_map, "Prediction failed", 503) | ||
| return create_predict_response(None, req_id_map, "Prediction failed : [{}]".format(e), 503) |
There was a problem hiding this comment.
No, this is bad practice to return exception details to client for unknown generic exceptions, as it can expose sensitive implementation details.
It would be fine to log the original exception though when wrapping in generic message.
Even without patch, the model code can use mms.PredictionException to preserve error code and message (see line 109 just a few lines above this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before or while filing an issue please feel free to join our
slack channel to get in touch with development team, ask questions, find out what's cooking and more!
Issue #, if available:
Description of changes:
Caught the exception of the invoking entry point and returned the failure as part of the response
Testing done: Yes (Ran the CI tests and all passed. )
To run CI tests on your changes refer README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.