Support the new hook types of newer oci spec #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the new hooks that deprecate prestart: * createContainer * createRuntime * startContainer Note that you need to be on container runtime that supports the OCI runtime spec >= v1.0.2 to manipulate these hooks, so I didn't add it into the README.
|
Hi @solarkennedy, thanks for opening this PR! When I look at the diff though, the only things I see changed are |
|
Whoops! I was comparing my branch to my fork's |
|
Thanks @solarkennedy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new hooks that deprecate prestart in newer versions of containerd:
Note that you need to be on container runtime that supports
the OCI runtime spec >= v1.0.2 to manipulate these hooks,
so I didn't add it into the README, but at least this tool will understand them if present.
Relates to opencontainers/runtime-spec#1008
cc @alban
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.