Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Natural Earth to registry #853

Merged
merged 14 commits into from
Aug 24, 2021
Merged

add Natural Earth to registry #853

merged 14 commits into from
Aug 24, 2021

Conversation

nvkelso
Copy link
Contributor

@nvkelso nvkelso commented Feb 13, 2021

stub of natural earth registry

@nvkelso
Create naturalearth.yaml
f66e35d 
stub of natural earth registry
@nvkelso nvkelso marked this pull request as draft February 13, 2021 06:30
@nvkelso nvkelso changed the title WIP: Create naturalearth.yaml WIP: add Natural Earth to registry Feb 13, 2021
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: f66e35d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nvkelso
comment out todos
5b14ae3 
Keep CI happy
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 5b14ae3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 244e4e4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nvkelso
Update naturalearth.yaml
17aafbc 
Use more convincing placeholder values
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 17aafbc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: c2c3115
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nvkelso
Nits
395c7bb 
Link out to NACIS
Reorder tags
Change resource description
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 395c7bb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nvkelso
Add publication
71e4431 
It's PDF from 2009 but it's the OG
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 71e4431
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 397cf28
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nvkelso nvkelso mentioned this pull request Aug 24, 2021
Closed
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 5192130
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This was referenced Aug 24, 2021
Closed
Open
@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 672bca3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 40e13d2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: 169e494
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@awsopendata
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: open-data-registry
  • Commit ID: d7766b2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

zflamig
zflamig reviewed Aug 24, 2021
View reviewed changes
datasets/naturalearth.yaml Outdated Show resolved Hide resolved
@nvkelso nvkelso marked this pull request as ready for review August 24, 2021 06:08
@nvkelso nvkelso changed the title WIP: add Natural Earth to registry add Natural Earth to registry Aug 24, 2021
@nvkelso
Copy link
Contributor Author

nvkelso commented Aug 24, 2021

There's obviously been some churn in the YAML file here, but it seems to pass now.

If there's anything else you want me to add let me know.

@barronh
Copy link

barronh commented Aug 24, 2021

+1
Having this as a part of the registry would be useful for many public users.

@jflasher
Copy link
Contributor

Thanks @nvkelso and no worries on the commits, this is what squash & merge is for. :)

@jflasher jflasher merged commit 67e259d into awslabs:main Aug 24, 2021
@greglucas greglucas mentioned this pull request Aug 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zflamig zflamig zflamig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nvkelso @awsopendata @barronh @jflasher @zflamig