Cleanup in geodata.hpp/cpp
#154
Conversation
sebastiangrimberg
force-pushed
the
sjg/geodata-updates
branch
2 times, most recently
from
b612c06 to
c3866a3
Compare
sebastiangrimberg
force-pushed
the
sjg/build-system-updates
branch
from
7c34cce to
a369a6a
Compare
sebastiangrimberg
force-pushed
the
sjg/build-system-updates
branch
2 times, most recently
from
6575381 to
0f520fb
Compare
sebastiangrimberg
force-pushed
the
sjg/geodata-updates
branch
from
c3866a3 to
d62f431
Compare
| @@ -1020,18 +1020,17 @@ void WavePortOperator::PrintBoundaryInfo(const IoData &iodata, mfem::ParMesh &me | |||
| continue; | |||
| } | |||
| const int attr = i + 1; | |||
| mfem::Vector nor; | |||
| mesh::GetSurfaceNormal(mesh, attr, nor); | |||
| mfem::Vector normal = mesh::GetSurfaceNormal(mesh, attr); | |||
There was a problem hiding this comment.
Minor: maybe auto for these GetSurfaceNormal? Reducing the number of mfem::Vector in the repo seems worthwhile, to avoid possible confusion on when to use which.
| std::sort(attributes.begin(), attributes.end()); | ||
| attributes.erase(unique(attributes.begin(), attributes.end()), attributes.end()); |
There was a problem hiding this comment.
I like avoiding the expensive resorting on every insert for set, given we only care about the sorted and unique invariant after they're fully collected. I'm assuming the possible duplication/size issues of attributes for all of these aren't concerning either.
Might consider shrink_to_fit on these attribute vectors after this unique, given they shouldn't be changed again.
There was a problem hiding this comment.
Done in 7eb7ec.
palace/utils/geodata.cpp
Outdated
| { | ||
| // MeshGenerator is reduced over the communicator. This checks for geometries on any | ||
| // processor. | ||
| auto meshgen = mesh.MeshGenerator(); | ||
| auto meshgen = const_cast<mfem::Mesh &>(mesh).MeshGenerator(); |
There was a problem hiding this comment.
That's so annoying of MeshGenerator(), no reason that shouldn't be const.
There was a problem hiding this comment.
This is actually no longer needed after the patch from #151 (from mfem/mfem#4019).
sebastiangrimberg
force-pushed
the
sjg/geodata-updates
branch
from
67eb7ec to
bfe2643
Compare
|
#164 minor mfem patch for the segfault issue with |
Patch for ParNCMesh::Update bug
Minor cleanup of geodata helper functions and declarations, in preparation for
palace::Meshclass. Includes someconstcorrectness fixes formfem::Meshenabled by #151.