-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMR example and test coverage #255
Conversation
Hi @simbilod, not sure if you're still working on this but it looks like a great contribution to the documentation: it's nice to see amr gaining traction. I think we'll probably want to expand this in a few ways though before any merge:
|
Hi @hughcars , thanks for the feedback! Yes showcasing a problem that benefits more from AMR is a good idea. I can take another crack in the coming week or so. |
Closing to redo with provided feedback down the line |
Description of changes:
Adds a new section to the "cavity eigenmodes" example showing convergence behaviour with adaptive mesh refinement and enabling AMR test coverage (as discussed in #221)
cavity.jl
to setup the simulation with AMRamr.jl
; parameters are chosen for quick execution, but still showing the effectcavity.md
documentation showcasing the plotsNew doc section:
Issue #, if available:
Addresses #221
Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute
this contribution, under the terms of your choice.