Skip to content

Fix bug for comsol mesh element reading #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix bug for comsol mesh element reading #361

merged 1 commit into from
Mar 28, 2025

Conversation

hughcars
Copy link
Collaborator

Revert change that introduced bug with extra arguments on compare:

Verification failed: (skip_type || num_elem_nodes == ElemNumNodes[elem_type - 1]) is false:
 --> Mismatch between COMSOL and Gmsh element types!
 ... in function: void palace::mesh::ConvertMeshComsol(const std::string&, std::ostream&, bool)
 ... in file: /data/home/hughcars/palace/palace/utils/meshio.cpp:851

when loading a comsol mesh.

@hughcars hughcars added bug Something isn't working minor A minor issue or improvement. Semantic versioning minor increment. labels Mar 28, 2025
@hughcars hughcars force-pushed the hughcars/comsol-mesh-bugfix branch from 602918e to de94f5f Compare March 28, 2025 18:14
@hughcars hughcars merged commit 10a1313 into main Mar 28, 2025
26 of 27 checks passed
@hughcars hughcars deleted the hughcars/comsol-mesh-bugfix branch March 28, 2025 20:26
@hughcars hughcars mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working minor A minor issue or improvement. Semantic versioning minor increment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hughcars