Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing bignum_copy_row_from_table on x86 #109

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

aqjune-aws
Copy link
Collaborator

I would like to have this reviewed after #108 is merged to avoid possible merge conflicts.

This is a small patch that enables testing bignum_copy_row_from_table on the x86 architecture.

This had to be done in the past when the x86 implementation was being added, but was missing.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This enables testing bignum_copy_row_from_table on the x86 architecture.

This had to be done in the past when the x86 implementation was being added, but was missing.
Copy link
Contributor

@jargh jargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a good idea. I have tried the modified code and it works as expected, performing the benchmarking also on x86.

@aqjune-aws aqjune-aws merged commit 26bfe44 into awslabs:main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants