Skip to content

Fix ci to propogate failures #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 28, 2019
Merged

Fix ci to propogate failures #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b08c0dc
failing CI if codebuild fails
Vikas-kum Dec 27, 2019
b777e06
Adding duration arg to pytest to find long running tests
Vikas-kum Dec 27, 2019
d719849
fixing duration argument
Vikas-kum Dec 27, 2019
93c9b22
set to fail on pipe failures
Vikas-kum Dec 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/buildspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,5 @@ phases:
- . $CODEBUILD_SRC_DIR/config/upload_on_end.sh
- rm -rf $CODEBUILD_SRC_DIR/upload/$CURRENT_COMMIT_PATH
- rm -rf $RULES_CODEBUILD_SRC_DIR/upload/$CURRENT_COMMIT_PATH
- if [ "$CODEBUILD_BUILD_SUCCEEDING" -eq 0 ]; then echo "ERROR BUILD FAILED " && exit 1 ; fi
- if [ "$CODEBUILD_BUILD_SUCCEEDING" -eq 1 ]; then echo "INFO BUILD SUCCEEDED !!! " ; fi
8 changes: 5 additions & 3 deletions config/tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/usr/bin/env bash

set -e
set -ex
set -o pipefail

check_logs() {
if grep -e "AssertionError" $1;
Expand All @@ -13,7 +15,7 @@ check_logs() {
}

run_for_framework() {
python -m pytest --html=$REPORT_DIR/report_$1.html -v -s --self-contained-html tests/$1
python -m pytest --durations=50 --html=$REPORT_DIR/report_$1.html -v -s --self-contained-html tests/$1
}

export TF_CPP_MIN_LOG_LEVEL=1
Expand All @@ -23,8 +25,8 @@ export SMDEBUG_LOG_LEVEL=info

export OUT_DIR=upload/$CURRENT_COMMIT_PATH
export REPORT_DIR=$OUT_DIR/pytest_reports
python -m pytest -v -W=ignore --html=$REPORT_DIR/report_analysis.html --self-contained-html tests/analysis
python -m pytest -v -W=ignore --html=$REPORT_DIR/report_core.html --self-contained-html tests/core
python -m pytest -v -W=ignore --durations=50 --html=$REPORT_DIR/report_analysis.html --self-contained-html tests/analysis
python -m pytest -v -W=ignore --durations=50 --html=$REPORT_DIR/report_core.html --self-contained-html tests/core

if [ "$run_pytest_xgboost" = "enable" ] ; then
run_for_framework xgboost
Expand Down