Skip to content

Update comments to refer to SM metrics #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Update comments to refer to SM metrics #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smdebug/core/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class CollectionKeys:
LOSSES = "losses"
BIASES = "biases"

# Use this collection to log scalars other than losses/metrics to Minerva.
# Use this collection to log scalars other than losses/metrics to SageMaker.
# Mainly for Tensorflow. For all other frameworks, call save_scalar() API
# with details of the scalar to be saved.
SM_METRICS = "sm_metrics"
Expand Down
6 changes: 3 additions & 3 deletions smdebug/core/hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def _write_scalars(self):
"""
This function writes all the scalar values saved in the scalar_cache to file.
If sm_metric is set to True for certain scalars, then that scalar is written to
Minerva as well. By default, loss values are sm_metric.
SageMaker as well. By default, loss values are sm_metric.
"""
for scalar_obj in self.scalar_cache:
scalar_name = scalar_obj.name
Expand Down Expand Up @@ -598,7 +598,7 @@ def save_scalar(self, name, value, sm_metric=False):
:param name: Name of the scalar. A prefix 'scalar/' will be added to it
:param value: Scalar value
:param sm_metric: True/False. If set to True, the scalar value will be written to
SageMaker Minerva
SageMaker
"""
name = CallbackHook.SCALAR_PREFIX + name
val = self._make_numpy_array(value)
Expand Down Expand Up @@ -662,7 +662,7 @@ def _save_for_tensor(self, tensor_name, tensor_value, check_before_write=True):
for s_col in save_collections_for_tensor:
if s_col.name in SM_METRIC_COLLECTIONS:
np_val = self._make_numpy_array(tensor_value)
# Always log loss to Minerva
# Always log loss to SageMaker
tensor_val = np.mean(np_val)
scalar_obj = ScalarCache(
tensor_name,
Expand Down