Skip to content

Disable TB in ZCC for AWS TF 2.3.0 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Disable TB in ZCC for AWS TF 2.3.0 #316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87697f2
disable tb testing
NihalHarish Aug 6, 2020
0082250
pythonic if
NihalHarish Aug 6, 2020
8d35e3c
merge ifs
NihalHarish Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/zero_code_change/test_tensorflow2_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def helper_test_keras_v2(script_mode: bool = False, eager_mode: bool = True):
# v1 training APIs are currently not supported
# in ZCC mode with smdebug 0.9 and AWS TF 2.3.0
tf.compat.v1.disable_eager_execution()
enable_tb = False if tf.__version__ == "2.0.2" else True

# Performance regression in the _make_histogram fn
enable_tb = False if tf.__version__ == "2.0.2" or is_tf_2_3() else True
with SagemakerSimulator(enable_tb=enable_tb) as sim:
model = get_keras_model_v2()
(x_train, y_train), (x_test, y_test) = get_keras_data()
Expand Down Expand Up @@ -118,7 +120,10 @@ def helper_test_keras_v2_json_config(
# v1 training APIs are currently not supported
# in ZCC mode with smdebug 0.9 and AWS TF 2.3.0
tf.compat.v1.disable_eager_execution()
enable_tb = False if tf.__version__ == "2.0.2" else True

# Performance regression in the _make_histogram fn
enable_tb = False if tf.__version__ == "2.0.2" or is_tf_2_3() else True

with SagemakerSimulator(json_file_contents=json_file_contents, enable_tb=enable_tb) as sim:
model = get_keras_model_v2()
(x_train, y_train), (x_test, y_test) = get_keras_data()
Expand Down