Skip to content

list training jobs improvements #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2020
Merged

list training jobs improvements #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
882036f
list training jobs improvments
Vikas-kum Sep 13, 2020
d5f7ec2
fix
Vikas-kum Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion smdebug/rules/action/stop_training_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def _get_sm_tj_jobs_with_prefix(self):
next_token = None
name = self._training_job_prefix
i = 0
exception_caught_times = 0
while i < 50:
try:
if next_token is None:
Expand All @@ -49,7 +50,7 @@ def _get_sm_tj_jobs_with_prefix(self):
self._logger.info(
f"No TrainingJob summaries found: list_training_jobs output is : {res}"
)
return
return []
for job in jobs:
tj_status = job["TrainingJobStatus"]
tj_name = job["TrainingJobName"]
Expand All @@ -61,13 +62,22 @@ def _get_sm_tj_jobs_with_prefix(self):
self._logger.info(
f"Caught exception while getting list_training_job exception is: \n {e}. Attempt:{i}"
)
exception_caught_times += 1
if exception_caught_times > 5:
print("Got exception more than 5 times while finding training job. Giving up.")
break
if "NextToken" not in res:
break
else:
next_token = res["NextToken"]
res = {}
jobs = {}
i += 1
if len(found_job_dict) > 0:
print(
f"Found training jobs matching prefix:{name}. Exiting even if next_token:{next_token} was present."
)
break

return found_job_dict.keys()

Expand Down