Skip to content

Pinning the version of tensorflow_datasets package so that it does not require updating TF #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Pinning the version of tensorflow_datasets package so that it does not require updating TF #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
278d006
Pinning the version of tensorflow_datasets package so that it does no…
leleamol Oct 14, 2020
fae816f
Pinning the version of tensorflow_datasets package so that it does no…
leleamol Oct 14, 2020
e7f970b
Fixing CI for xgboost
leleamol Oct 14, 2020
05128d9
Addressed the review comments to move the installation closer to fram…
leleamol Oct 14, 2020
1a62aec
comments and unpin pytest
NihalHarish Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions config/buildspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ phases:
- cd $CODEBUILD_SRC_DIR && chmod +x config/protoc_downloader.sh && ./config/protoc_downloader.sh
- pip install --upgrade pip==19.3.1
- if [ "$run_pytest_xgboost" = "enable" ]; then pip install --upgrade pyYaml==5.1; else pip install -q pyYaml; fi
- pip install -q pytest==5.3.3 wheel pytest-html pre-commit awscli tensorflow_datasets pytest-cov
- pip install -q pytest wheel pytest-html pre-commit awscli pytest-cov

pre_build:
commands:
Expand All @@ -39,7 +39,8 @@ phases:
build:
commands:
- cd $CODEBUILD_SRC_DIR && python setup.py bdist_wheel --universal
- cd $RULES_CODEBUILD_SRC_DIR && python setup.py bdist_wheel --universal && pip install --force-reinstall dist/*.whl && cd ..
- cd $RULES_CODEBUILD_SRC_DIR && python setup.py bdist_wheel --universal
- if [ "$run_pytest_xgboost" = "enable" ]; then pip install --force-reinstall $RULES_CODEBUILD_SRC_DIR/dist/*.whl; else pip install $RULES_CODEBUILD_SRC_DIR/dist/*.whl; fi
- cd $CODEBUILD_SRC_DIR && pip install --force-reinstall dist/*.whl && cd ..
- cd $CODEBUILD_SRC_DIR && chmod +x config/tests.sh && PYTHONPATH=. && ./config/tests.sh && mkdir -p upload/$CURRENT_COMMIT_PATH/wheels && cp ./dist/*.whl upload/$CURRENT_COMMIT_PATH/wheels && cd ..
- pip show smdebug
Expand Down
2 changes: 1 addition & 1 deletion config/buildspec_build_wheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ phases:
- sudo apt-get install unzip -qq -o=Dpkg::Use-Pty=0
- cd $CODEBUILD_SRC_DIR && chmod +x config/protoc_downloader.sh && ./config/protoc_downloader.sh
- pip install --upgrade pip==19.3.1
- pip install -q pytest==5.3.3 wheel pyYaml pytest-html pre-commit pytest-cov
- pip install -q pytest wheel pyYaml pytest-html pre-commit pytest-cov
- pip uninstall -y boto3 && pip uninstall -y aiobotocore && pip uninstall -y botocore

build:
Expand Down
2 changes: 1 addition & 1 deletion config/buildspec_vanilla_framework_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ phases:
- sudo apt-get install unzip -qq -o=Dpkg::Use-Pty=0
- cd $CODEBUILD_SRC_DIR && chmod +x config/protoc_downloader.sh && ./config/protoc_downloader.sh
- pip install --upgrade pip==19.3.1
- pip install -q pytest==5.3.3 pytest-cov wheel pyYaml pytest-html keras==2.3.1 mxnet torch xgboost pre-commit tensorflow_datasets torchvision
- pip install -q pytest pytest-cov wheel pyYaml pytest-html keras==2.3.1 mxnet torch xgboost pre-commit tensorflow_datasets torchvision
- cd $CODEBUILD_SRC_DIR && chmod +x config/install_smdebug.sh && chmod +x config/check_smdebug_install.sh && ./config/install_smdebug.sh;

build:
Expand Down
2 changes: 1 addition & 1 deletion config/buildspec_zero_code_change.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ phases:
- sudo apt-get install unzip -qq -o=Dpkg::Use-Pty=0
- cd $CODEBUILD_SRC_DIR && chmod +x config/protoc_downloader.sh && ./config/protoc_downloader.sh
- pip install --upgrade pip==19.3.1
- pip install -q pytest==5.3.3 wheel pyYaml pytest-html pre-commit awscli tensorflow_datasets pytest-cov
- pip install -q pytest wheel pyYaml pytest-html pre-commit awscli pytest-cov
- cd $CODEBUILD_SRC_DIR && chmod +x config/install_smdebug.sh && chmod +x config/check_smdebug_install.sh && ./config/install_smdebug.sh;

build:
Expand Down
3 changes: 3 additions & 0 deletions config/tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,13 @@ if [ "$run_pytest_xgboost" = "enable" ] ; then
fi

if [ "$run_pytest_tensorflow" = "enable" ] ; then
# tensorflow_datasets >= 4.0.0 requires tensorflow >= 2.1.0
pip install tensorflow_datasets==3.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the reason for the version pin here?

run_for_framework tensorflow
fi

if [ "$run_pytest_tensorflow2" = "enable" ] ; then
pip install tensorflow_datasets
run_for_framework tensorflow2
fi

Expand Down