Cache TF Versions #421
Merged
Cache TF Versions #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorgoggins
approved these changes
Jan 13, 2021
Contributor
connorgoggins
left a comment
connorgoggins
left a comment
There was a problem hiding this comment.
Non-blocking: might also be worth updating smdebug/tensorflow/version_check.py, tests/tensorflow2/utils.py, tests/zero_code_change/smdataparallel_tests/tensorflow2/test_tf2_smdataparallel.py, tests/zero_code_change/test_tensorflow2_integration.py, etc. to use the cached version as well.
ndodda-amazon
suggested changes
Jan 13, 2021
Contributor
ndodda-amazon
left a comment
ndodda-amazon
left a comment
There was a problem hiding this comment.
Changes look good! Can we cache the PyTorch versions as well for consistency?
ndodda-amazon
approved these changes
Jan 13, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 22, 2021
NihalHarish
added a commit
that referenced
this pull request
Jan 25, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 29, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
version.parse(tf.__version__)Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.