Test Updates For TF 2.4 #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 77.70% 75.20% -2.51%
==========================================
Files 113 113
Lines 10143 10143
==========================================
- Hits 7882 7628 -254
- Misses 2261 2515 +254
Continue to review full report at Codecov.
|
ndodda-amazon
suggested changes
Jan 14, 2021
Contributor
ndodda-amazon
left a comment
ndodda-amazon
left a comment
There was a problem hiding this comment.
Looks good, left a minor comment.
smdebug/tensorflow/utils.py
Outdated
|
|
||
| def is_profiler_supported_for_tf_version(): | ||
| return is_tf_version_2_2_x() or is_tf_version_2_3_x() | ||
| return is_tf_version_2_2_x() or is_tf_version_2_3_x() or is_tf_version_greater_than_2_4_x() |
Contributor
There was a problem hiding this comment.
Two nits:
- Maybe we can just simplify this and do
return version.parse("2.2.0") <= TF_VERSION - Naming schema clashes with
is_tf_version_greater_than_2_4_x, we should just rename this function tois_tf_version_greater_than_2_2_xor renameis_tf_version_greater_than_2_4_xappropriately.
NihalHarish
changed the title
ndodda-amazon
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
tf2_4.ymlbuildspec to test the changes on a custom version of tf 2.4.0 gpuis_profiler_supportedfunction to include tf 2.4.0Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.