Skip to content

Pass iteration_number to metrics.log_metric as keyword argument. Fix … #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Pass iteration_number to metrics.log_metric as keyword argument. Fix … #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion smdebug/core/hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,8 @@ def _write_scalars(self):
write_tb = scalar_obj.write_tb
write_event = scalar_obj.write_event
if self.metrics_writer and sm_metric:
self.metrics_writer.log_metric(scalar_name, scalar_val, self.mode_steps[self.mode])
self.metrics_writer.log_metric(scalar_name, scalar_val,
iteration_number=self.mode_steps[self.mode])
Comment on lines +572 to +573
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the timestamp? Why aren't we including that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is set by default to time.time()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, Owen mentioned online this is set to default time.time() by the Eureka SDK, if not provided by the caller. I'm ok with this.

if write_tb:
tb_writer = self._maybe_get_tb_writer()
if tb_writer:
Expand Down