Update panic message in UncontrolledNondeterminismCheckScheduler to be less verbose #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarsko
force-pushed
the
update-panic-msg
branch
2 times, most recently
from
3993611 to
71bddb3
Compare
sarsko
force-pushed
the
update-panic-msg
branch
from
71bddb3 to
6e9aaf9
Compare
sarsko
changed the title
jorajeev
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to
Schedulermaking it take&[&Task]s instead of&[&TaskId]s, made this panic message needlessly verbose.runnablesisTaskIds, andrunnable_tasksisTasks, which makes it hard to discover the difference in tasks.Updated the panic message to make it easier to spot the difference while at it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.