Fix two instances of elided_named_lifetimes warning #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo check` on 1.83 currently fails due to the use of `#[deny(warnings)]`
because of two occurrences of the `elided_named_lifetimes` warning,
as shown below:
```
error: elided lifetime has a name
--> src/lazy_static.rs:48:34
|
48 | pub fn get(&'static self) -> &T {
| ^ this elided lifetime gets resolved as `'static`
|
note: the lint level is defined here
--> src/lib.rs:1:9
|
1 | #![deny(warnings, missing_debug_implementations, missing_docs)]
| ^^^^^^^^
= note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]`
help: consider specifying it explicitly
|
48 | pub fn get(&'static self) -> &'static T {
| +++++++
```
This commit fixes both of the warnings by applying the recommended
fix. Since the elided lifetime is resolved to be `'static` anyways,
there's no change in behavior.
This commit fixes a few Clippy warnings that are set to `deny` and therefore cause CI checks in pull requests to fail. I verified that `cargo clippy --all-targets --all-features` succeeds (with no warnings nor errors) after the fixes.
bkragl
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo checkon 1.83 currently fails due to the use of#[deny(warnings)]because of two occurrences of theelided_named_lifetimeswarning, as shown below:This commit fixes both of the warnings by applying the recommended fix. Since the elided lifetime is resolved to be
'staticanyways, there's no change in behavior.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.