Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add tracer unit tests #16

Merged
merged 3 commits into from
Jan 25, 2023
Merged

[Test] Add tracer unit tests #16

merged 3 commits into from
Jan 25, 2023

Conversation

chhzh123
Copy link
Contributor

Description

This PR updates the unit tests for tracer. Also, it adds a syntactic sugar for users to easily retrieve submodules in nn.Sequential. For example, previously, users can only use sch["layer1"]["0"]["downsample"] to access submodules in WideResNet. This PR enables the sch["layer1.0.downsample"] access.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@chhzh123 chhzh123 mentioned this pull request Jan 24, 2023
15 tasks
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. You could add a new commit to trigger the CI. It should work now.

slapo/schedule.py Outdated Show resolved Hide resolved
slapo/schedule.py Outdated Show resolved Hide resolved
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 36c0f46 into awslabs:main Jan 25, 2023
@comaniac
Copy link
Contributor

Thanks @chhzh123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants