Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pipeline] Drop last batch in DeepSpeed scripts #19

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

comaniac
Copy link
Contributor

Description

The DeepSpeed pipeline runtime doesn't support dynamic batch, meaning that the last batch may cause hanging. This PR drops the last batch to workaround this issue.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

cc @szhengac @zarzen

@szhengac szhengac merged commit 7c8f115 into awslabs:main Jan 26, 2023
szhengac pushed a commit to szhengac/slapo that referenced this pull request Jan 27, 2023
@comaniac comaniac deleted the fix_hang branch February 3, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants