Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix a small device bug #57

Merged
merged 6 commits into from
Feb 16, 2023
Merged

[Bugfix] Fix a small device bug #57

merged 6 commits into from
Feb 16, 2023

Conversation

szhengac
Copy link
Contributor

Initialize all-gather tensor on gpu.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@chhzh123
Copy link
Contributor

This line also uses .to(device). Maybe we can also change it?
https://github.com/awslabs/slapo/blob/main/slapo/framework_dialect/deepspeed/pipeline.py#L320

@szhengac
Copy link
Contributor Author

This line also uses .to(device). Maybe we can also change it? https://github.com/awslabs/slapo/blob/main/slapo/framework_dialect/deepspeed/pipeline.py#L320

Nice catch!

slapo/schedule.py Outdated Show resolved Hide resolved
@comaniac comaniac merged commit a82f501 into awslabs:main Feb 16, 2023
@comaniac
Copy link
Contributor

Thanks @szhengac @chhzh123

@szhengac szhengac deleted the device branch February 16, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants