Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the schedule primitives to make them more systematic and extensible:
Primitive
that defines the required APIs (name
,apply
, and optionalinit_metadata
).apply
function takes the schedule as the first argument, followed by any primitive specific arguments.init_metadata
allows each primitive to register their metadata, so the original schedule metadata only defines tie_weights metadata now. Meanwhile, we currently also put some metadata, such as the original shape before sharding, directly to nn.Parameter. I'll send a follow-up PR to better organize them.In addition this PR also
build.py
.get_output_type_after_sharding
topostproc_sharding
, because this function not only infers the output type but also changes the attributes (e.g.,in_feature
) after sharding.Checklist
cc @chhzh123