Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Refactor dataloader to support BERT #79

Merged
merged 5 commits into from
Mar 14, 2023
Merged

[examples] Refactor dataloader to support BERT #79

merged 5 commits into from
Mar 14, 2023

Conversation

chhzh123
Copy link
Contributor

Description

This PR changes BERT's training script to load from the real wikipedia dataset. It refactors the data_util.py file in order to support different models and datasets.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@chhzh123 chhzh123 requested a review from comaniac March 10, 2023 18:41
comaniac
comaniac approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chhzh123 chhzh123 merged commit c02ac42 into awslabs:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chhzh123 @comaniac