Skip to content

Conversation

@fabianfett
Copy link
Contributor

…back

@fabianfett fabianfett requested a review from tomerd June 4, 2020 07:33
@tomerd
Copy link
Contributor

tomerd commented Jun 6, 2020

thanks @fabianfett this is probably the right thing to do given #107. I think we should also update the examples in the Examples directories as they additional source of copy/paste

Also, from a formatting pov, why break the signature to a separate line?

@tomerd tomerd added this to the 0.1.1 milestone Jun 6, 2020
@fabianfett fabianfett force-pushed the ff-explicit-type-docu branch from 9d65293 to e3c40d7 Compare June 7, 2020 11:28
@fabianfett
Copy link
Contributor Author

@tomerd I've added the line breaks to ensure the callback is better visible in mobile.

Screen Shot 2020-06-07 at 13 22 01

Removed them for now though

@fabianfett fabianfett force-pushed the ff-explicit-type-docu branch from e3c40d7 to b8ea13c Compare June 7, 2020 11:39
@fabianfett
Copy link
Contributor Author

@swift-server-bot test this please

@fabianfett fabianfett force-pushed the ff-explicit-type-docu branch from b8ea13c to 08aae2e Compare June 7, 2020 14:53
@fabianfett fabianfett force-pushed the ff-explicit-type-docu branch from 08aae2e to 22845fc Compare June 7, 2020 15:01
@tomerd tomerd merged commit a5e2fd0 into awslabs:master Jun 7, 2020
@fabianfett fabianfett deleted the ff-explicit-type-docu branch June 7, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants