async/await support #186
async/await support #186
Conversation
|
Node.js developers will feel at home :-) But we would need Seems to be in the pipeline :-) |
|
This might be interesting to us. Potentially replacing the |
fabianfett
force-pushed
the
async-await
branch
4 times, most recently
from
d6b3b48 to
3f849a0
Compare
| /// - closure: `CodableVoidAsyncClosure` based Lambda. | ||
| /// | ||
| /// - note: This is a blocking operation that will run forever, as its lifecycle is managed by the AWS Lambda Runtime Engine. | ||
| public static func run<In: Decodable>(_ closure: @escaping CodableVoidAsyncClosure<In>) { |
There was a problem hiding this comment.
overloading on closure arguments is probably not a good idea
|
|
||
| #if compiler(>=5.5) && $AsyncAwait | ||
| /// Strongly typed, processing protocol for a Lambda that takes a user defined `In` and returns a user defined `Out` async. | ||
| public protocol AsyncLambdaHandler: EventLoopLambdaHandler { |
There was a problem hiding this comment.
hmm, an AsyncLambdaHandler isn't running the async code on the EventLoop at the moment (that's impossible without custom executors), is this proto conformance still right?
There was a problem hiding this comment.
Yes it is. Those protocols build up on top of each other:
- ByteBufferLambdaHandler (just receive ByteBuffer on the EnventLoop)
- EventLoopLambdaHandler (implements encoding and decoding to other types) - still on EventLoop
- AsyncLambdaHandler - implements
EventLoopLambdaHandlerby dispatching of theEventLoop.
fabianfett
force-pushed
the
async-await
branch
3 times, most recently
from
2b6292d to
b9e39fe
Compare
Package.swift
Outdated
|
|
||
| #if compiler(>=5.5) && $AsyncAwait | ||
| package.targets.first(where: { $0.name == "AWSLambdaRuntimeCore" })? | ||
| .dependencies.append(.product(name: "_NIOConcurrency", package: "swift-nio")) |
There was a problem hiding this comment.
you can always depend on it, _NIOConcurrency just doesn't export anything if A/A isn't on. But up to you
|
|
||
| // MARK: - Async | ||
|
|
||
| #if compiler(>=5.5) && $AsyncAwait |
There was a problem hiding this comment.
this is good stuff. should we also mark the closure ones deprecated >= 5.5? I would argue we should.
Package.swift
Outdated
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-nio.git", .upToNextMajor(from: "2.17.0")), | ||
| .package(url: "https://github.com/apple/swift-nio.git", .branch("main")), |
There was a problem hiding this comment.
We need to wait for the next NIO release before we can merge. @weissi ;)
fabianfett
force-pushed
the
async-await
branch
2 times, most recently
from
66b8fcc to
9e32a33
Compare
Co-authored-by: tomer doron <tomerd@apple.com>
|
@swift-server-bot test this please |
|
awesome! |
4 participants
async/awaitis awesome! Let's support this in Lambda.Modifications:
AsyncLambdaHandler. Will be renamed toLambdaHandleras soon as we drop the current callback basedLambdaHandler.AsyncLambdaHandleris to use@mainto execute it. Don't useLambda.runfor it. We wan't to removeLambda.runfor 1.0.