Skip to content

Rename Lambda.Lifecycle to LambdaRuntime #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2021
Merged

Rename Lambda.Lifecycle to LambdaRuntime #232

merged 1 commit into from
Sep 29, 2021

Conversation

@fabianfett
Copy link
Contributor

Rename Lambda.Lifecycle to LambdaRuntime. As follow ups we should remove the namespacing on all public types and just plainly prefix them with Lambda.

@fabianfett fabianfett added the ⚠️ semver/major Breaks existing public API. label Sep 28, 2021
@fabianfett fabianfett added this to the 1.0.0-alpha.1 milestone Sep 28, 2021
@fabianfett fabianfett requested a review from tomerd September 28, 2021 20:51
tomerd
tomerd approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, too bad git thinks it a completely new file

@fabianfett fabianfett merged commit afab510 into awslabs:main Sep 29, 2021
@fabianfett fabianfett deleted the ff-lambda-lifecycle-renamed-to-runtime branch September 29, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tomerd tomerd tomerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⚠️ semver/major Breaks existing public API.

Projects

None yet

Milestone

1.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett @tomerd