args: support plugin-specific JSON config #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `tc-redirect-tap` plugin only supports the arguments it receives via the `skel.CmdArgs` arguments, which in turn come the `CNI_ARGS` environment variable. To allow driving the configuration purely from files and bring the plugin configuration more in line with the default plugins, add support for plugin-specific JSON configuration. Signed-off-by: Tim Gross <tim@0x74696d.com>
tgross
force-pushed
the
args_from_json_config
branch
from
20358ed
to
c9a6163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
tc-redirect-tapplugin only supports the arguments it receives via theskel.CmdArgsarguments, which in turn come theCNI_ARGSenvironment variable. To allow driving the configuration purely from files and bring the plugin configuration more in line with the default plugins, add support for plugin-specific JSON configuration.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Signed-off-by: Tim Gross tim@0x74696d.com