Update CNI dependencies to v1.0.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IPConfig` in v1.0.0 removes the `Version` field. Add CNI version 0.4.0 to supported plugin versions along with the current version, 1.0.0. Signed-off-by: Sunny <darkowlzz@protonmail.com>
gaby
suggested changes
Oct 22, 2021
| @@ -3,11 +3,11 @@ module github.com/awslabs/tc-redirect-tap | |||
| go 1.11 | |||
|
|
|||
| require ( | |||
| github.com/containernetworking/cni v0.7.1 | |||
| github.com/containernetworking/plugins v0.8.6 | |||
| github.com/containernetworking/cni v1.0.0 | |||
| github.com/containernetworking/cni v0.7.1 | ||
| github.com/containernetworking/plugins v0.8.6 | ||
| github.com/containernetworking/cni v1.0.0 | ||
| github.com/containernetworking/plugins v1.0.0 |
| "github.com/awslabs/tc-redirect-tap/internal" | ||
| ) | ||
|
|
||
| func main() { | ||
| skel.PluginMain(add, check, del, | ||
| // support CNI versions that support plugin chaining | ||
| version.PluginSupports("0.3.0", "0.3.1", version.Current()), | ||
| version.PluginSupports("0.3.0", "0.3.1", "0.4.0", version.Current()), |
There was a problem hiding this comment.
This needs "1.0.0" added, which is the stable spec.
|
LGTM! Thanks. |
|
@kzys The PR was not ready for merge yet, the working version should be 1.0.1 In the 1.0.0 they forgot to add the 1.0.0 spec. I will send another PR in like 1-2 hours. |
|
Submitted #10 to fix the update to v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CNI dependencies to v1.0.0.
IPConfigin v1.0.0 removes theVersionfield, refer containernetworking/cni#783.Add CNI version 0.4.0 to the supported plugin versions along with the
current version, 1.0.0.
In an attempt to update the CNI dependencies in firecracker-go-sdk, I created firecracker-microvm/firecracker-go-sdk#351, but since fc-go-sdk depends on this repo, I updated the same here. Hope that's not a problem.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.